libnvme: Rename NVME_LOG_*_DISCOVER to NVME_LOG_*_DISCOVERY#2995
Closed
martin-belanger wants to merge 1 commit intolinux-nvme:masterfrom
Closed
libnvme: Rename NVME_LOG_*_DISCOVER to NVME_LOG_*_DISCOVERY#2995martin-belanger wants to merge 1 commit intolinux-nvme:masterfrom
martin-belanger wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
The following 3 types were renamed at some point, but not all instances were renamed in the docs and python examples. NVME_LOG_LID_DISCOVER -> NVME_LOG_LID_DISCOVERY NVME_LOG_LID_HOST_DISCOVER -> NVME_LOG_LID_HOST_DISCOVERY NVME_LOG_LID_AVE_DISCOVER -> NVME_LOG_LID_AVE_DISCOVERY Signed-off-by: Martin Belanger <[email protected]>
Collaborator
I'll fix it up myself next week (still busy with my hackweek project :)) unless you are faster than me :) |
Author
|
I will fix it today. I didn't realize the wrap file had been bundled in this PR. Not sure how this happened. |
Author
|
Closing. Will resubmit a fresh PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following 3 types were renamed at some point, but not all instances were renamed in the docs and python examples.